1. Forum
  2. FidoNet
  3. SYNC PROGRAMMING

  • src/syncterm/modem.c

    From Deucе@1:103/705 to Git commit to main/sbbs/master on Wednesday, November 20, 2024 10:18:44
    https://gitlab.synchro.net/main/sbbs/-/commit/ea864e01bc7bc0a5d9910e60
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Explicitly set serial port to 8N1

    Surely nobody uses anything else...
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wednesday, November 20, 2024 17:19:46
    https://gitlab.synchro.net/main/sbbs/-/commit/e3defcadd670c4a735b94fb1
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Set flow control before raising DTR

    Possibly setting CTS/RTS after raising DTR drops DTR which causes
    DCD to be lost.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Wednesday, November 20, 2024 20:41:35
    https://gitlab.synchro.net/main/sbbs/-/commit/3bd04233525aa4b20db983c1
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Because some USB modems suck (ie: USR5637), do software parity

    This is just in case the modem actually stays in 8N1 mode when
    7E1 or 7O1 is set. This is what the USR 5637 appears to do.

    There's a small performance penalty for anything in 7-bit mode with
    this, but it shouldn't be enough to actually impact anything.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Rob Swindell (on Debian Linux)@1:103/705 to Git commit to main/sbbs/master on Thursday, November 21, 2024 01:24:48
    https://gitlab.synchro.net/main/sbbs/-/commit/20c4351affe0a23e1353775d
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Resolve recently added compile errors and warnings

    to unblock the pipes
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Thursday, November 21, 2024 10:24:57
    https://gitlab.synchro.net/main/sbbs/-/commit/270605279256506a3cfa6caf
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    The USR modem isn't so bad that it needs parity generated

    We just need to strip the high bit on RX because the mode leaves
    it on received bytes.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Friday, January 03, 2025 00:40:51
    https://gitlab.synchro.net/main/sbbs/-/commit/ba5187ac13651a907fdfa558
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Fix types here too.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sunday, January 12, 2025 10:33:46
    https://gitlab.synchro.net/main/sbbs/-/commit/ffd0cdff85686d243ef47e45
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Whoops, forgot to remove the loop.

    Thanks coverity!
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sunday, January 12, 2025 10:52:19
    https://gitlab.synchro.net/main/sbbs/-/commit/124e6716c60d4d4dc3540e69
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Remove unused variable.
    --- SBBSecho 3.23-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sunday, March 15, 2026 14:09:13
    https://gitlab.synchro.net/main/sbbs/-/commit/8e965d4d31230d9722fdabaf
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Fix modem.c invalid handle use and data race

    - modem_close(): comGetModemStatus() was called on COM_HANDLE_INVALID
    instead of oldcom in the DCD polling loop.
    - Mark static com variable as _Atomic since it is written by the main
    thread (modem_close sets it to COM_HANDLE_INVALID) and read by the
    I/O threads in their loop conditions.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)
  • From Deucе@1:103/705 to Git commit to main/sbbs/master on Sunday, March 15, 2026 16:38:47
    https://gitlab.synchro.net/main/sbbs/-/commit/200f9122ee6ec2017a31a4b0
    Modified Files:
    src/syncterm/modem.c
    Log Message:
    Fix _Atomic compound assignment-and-compare on Darwin

    Apple clang rejects (atomic_var = expr) == value as invalid operands
    to binary expression. Split into separate assignment and comparison
    statements.

    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    --- SBBSecho 3.37-Linux
    * Origin: Vertrauen - [vert/cvs/bbs].synchro.net (1:103/705)